Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust benchmark, PR template #2276

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Adjust benchmark, PR template #2276

merged 3 commits into from
Sep 1, 2023

Conversation

westin-m
Copy link
Contributor

@westin-m westin-m commented Aug 29, 2023

For crank, the command must use dev7 until the benchmark app is merged into dev.

In the crank output for the microbenchmarks, several noisy columns are displayed. This change hides them.

Create a PR template that refers people to the benchmarking wiki page

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westin-m westin-m added this pull request to the merge queue Sep 1, 2023
Merged via the queue into dev7 with commit 8913b29 Sep 1, 2023
@westin-m westin-m deleted the westinm/adjustBenchmark branch September 1, 2023 18:29
@westin-m westin-m linked an issue Sep 1, 2023 that may be closed by this pull request
brentschmaltz pushed a commit that referenced this pull request Sep 6, 2023
* hide unneeded columns

* Create pull request template

* fix job args
brentschmaltz pushed a commit that referenced this pull request Sep 7, 2023
* hide unneeded columns

* Create pull request template

* fix job args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a PR template which includes the benchmarking
3 participants