Skip to content

Commit

Permalink
Adjust benchmark, PR template (#2276)
Browse files Browse the repository at this point in the history
* hide unneeded columns

* Create pull request template

* fix job args
  • Loading branch information
westin-m authored and brentschmaltz committed Sep 7, 2023
1 parent f05660a commit 32d7da7
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 4 deletions.
21 changes: 21 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# {PR title}
<!-- Thank you for submitting a pull request to our repo. -->

<!-- If this is your first PR in the IdentityModel repo, please run through the checklist
below to ensure a smooth review and merge process for your PR. -->

- [ ] You've read the [Contributor Guide](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/Contributing.md) and [Code of Conduct](https://opensource.microsoft.com/codeofconduct/).
- [ ] You've included unit or integration tests for your change, where applicable.
- [ ] You've included inline docs for your change, where applicable.
- [ ] If any gains or losses in performance are possible, you've included benchmarks for your changes. [More info](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/Benchmarking-in-Wilson)
- [ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

<!-- Once all that is done, you're ready to go. Open the PR with the content below. -->

Summary of the changes (Less than 80 chars)

## Description

{Detail}

Fixes #{bug number} (in this specific format)
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace Microsoft.IdentityModel.Benchmarks
{
[HideColumns("Type", "Job", "WarmupCount", "LaunchCount")]
public class CreateTokenTests
{
JsonWebTokenHandler jsonWebTokenHandler;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
namespace Microsoft.IdentityModel.Benchmarks
{
[Config(typeof(AntiVirusFriendlyConfig))]
[HideColumns("Type", "Job", "WarmupCount", "LaunchCount")]
public class ValidateTokenAsyncTests
{
JsonWebTokenHandler jsonWebTokenHandler;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ jobs:
benchmarks:
source:
repository: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet
branchOrCommit: dev7
project: benchmark\Microsoft.IdentityModel.Benchmarks\Microsoft.IdentityModel.Benchmarks.csproj
variables:
filterArg: "*"
Expand All @@ -14,11 +15,12 @@ jobs:
benchmarkDotNet: true

scenarios:
ValidateTokenAsyncTests:

ValidateToken:
application:
job: benchmarks
job: "*ValidateTokenAsyncTests*"

CreateTokenTests:
CreateToken:
application:
job: benchmarks
job: "*CreateTokenTests*"

0 comments on commit 32d7da7

Please sign in to comment.