Remove constraint on authorized_ip_ranges when public_network_access_enabled is true
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 task
skolobov
pushed a commit
to skolobov/terraform-azurerm-aks
that referenced
this pull request
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The change introduced by #361 was inspired by this commit from AzureRM provider. At that time, once you set
public_network_access_enabledtofalse,0.0.0.0/32would be added intoapi_server_authorized_ip_rangesfrom the service side, so a notice as been added into the document (which seems incorrect). But this behavior occurs no more today, so this pr just remove thispreconditionblock.Issue number
#370
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!