Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check api_server_authorized_ip_ranges when public_network_access_enabled is true #361

Merged
merged 5 commits into from
May 9, 2023
Merged

Check api_server_authorized_ip_ranges when public_network_access_enabled is true #361

merged 5 commits into from
May 9, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#313

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests May 6, 2023 09:33 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests May 8, 2023 07:10 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jiaweitao001 jiaweitao001 merged commit a4bedf7 into Azure:main May 9, 2023
@zioproto zioproto mentioned this pull request May 9, 2023
Closed
1 task
@zioproto zioproto mentioned this pull request May 20, 2023
Closed
1 task
lonegunmanb added a commit to lonegunmanb/terraform-azurerm-aks that referenced this pull request May 23, 2023
@lonegunmanb
revert change introduced by Azure#361
b1937e5
@lonegunmanb lonegunmanb mentioned this pull request May 23, 2023
Merged
3 tasks
lonegunmanb added a commit that referenced this pull request May 24, 2023
@lonegunmanb
revert change introduced by #361 (#375)
d4b203b
skolobov pushed a commit to skolobov/terraform-azurerm-aks that referenced this pull request Oct 29, 2023
@lonegunmanb @skolobov
revert change introduced by Azure#361 (Azure#375)
fbb3849
@lonegunmanb lonegunmanb deleted the e-313 branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001