Check crate packaging in ci #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarTHZhang
approved these changes
Jan 9, 2025
youyuanwu
pushed a commit
that referenced
this pull request
Jan 14, 2025
Prepare for 0.0.19 release #120 added CI packaging. Unfortunately, ```cargo package``` in 1.84 stable toolchain doesn't handle unpublished packages in the same workspace (but cargo publish does) This results in CI failures when bumping version (see #128). The solution is to use nightly feature ```-Z package-workspace```, which takes unpublished local versions into account. A call for testing (```https://github.com/rust-lang/cargo/issues/10948#issuecomment-2540365225```) went out for 1.85.0-nightly (2024-12-01) and newer. So install nightly as well and do that. Will need to be tweaked in a few months when that setting hopefully stabilizes. Also, replace action-rs/toolchain with dtolnay/rust-toolchain, since action-rs/toolchain is no longer maintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo publish or package builds crates from clean state and previously caught some bugs.
Enable the check in generate.yml ci to prevent future breaks. This does not prolong overall ci time because it runs in parallel to the build.yaml ci which takes much more time.
All so cleans up the feature usages in mssf. Removing bundled_libs feature since fabric-metadata crate deps has been removed.