-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prepare 0.0.19 Release with CI Packaging fix (#129)
Prepare for 0.0.19 release #120 added CI packaging. Unfortunately, ```cargo package``` in 1.84 stable toolchain doesn't handle unpublished packages in the same workspace (but cargo publish does) This results in CI failures when bumping version (see #128). The solution is to use nightly feature ```-Z package-workspace```, which takes unpublished local versions into account. A call for testing (```https://github.com/rust-lang/cargo/issues/10948#issuecomment-2540365225```) went out for 1.85.0-nightly (2024-12-01) and newer. So install nightly as well and do that. Will need to be tweaked in a few months when that setting hopefully stabilizes. Also, replace action-rs/toolchain with dtolnay/rust-toolchain, since action-rs/toolchain is no longer maintained.
- Loading branch information
1 parent
7be0df0
commit c046cd2
Showing
5 changed files
with
15 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,7 @@ jobs: | |
uses: lukka/[email protected] | ||
|
||
- name: Install rust stable | ||
uses: actions-rs/toolchain@v1 | ||
with: | ||
toolchain: stable | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: cmake configure | ||
run: > | ||
|
@@ -39,5 +37,9 @@ jobs: | |
- name: build rust code | ||
run: cmake --build build --config ${{ matrix.BUILD_TYPE }} | ||
|
||
- name: Install rust nightly | ||
uses: dtolnay/rust-toolchain@nightly | ||
|
||
- name: check crate packaging | ||
run: cargo package -p mssf-pal -p mssf-com -p mssf-core --allow-dirty | ||
# TODO: move back to stable once package-workspace is stabilized | ||
run: cargo +nightly -Z package-workspace package -p mssf-pal -p mssf-com -p mssf-core --allow-dirty |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters