Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVD Add-On: Added marketplace terms & other fixes #1134

Merged
merged 48 commits into from
Nov 27, 2024
Merged

AVD Add-On: Added marketplace terms & other fixes #1134

merged 48 commits into from
Nov 27, 2024

Conversation

jamasten
Copy link
Contributor

@jamasten jamasten commented Nov 27, 2024 •
edited
Loading

Description

  • Added run command script and VM plan to set marketplace terms for ESRI image
  • Fix API versions for MAG
  • Added condition for role assignment
  • Updated tags to use safe dereference
  • Simplified resource naming
  • Added a better UI element for security groups
  • Moved control plane resources to mgmt resource group
  • Fixed function app SKU for US GOV Arizona & PowerShell version
  • Removed VM size constraints in Imaging add-on UI

Issue reference

The issue this PR will close: #1129

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@jamasten
Fixed API versions for MAG
fd098be
@jamasten
Added condition for role assignment
c4b8716
@jamasten
Fixed API version for MAG
a94ace0
@jamasten
Fixed API version for MAG
d0c461a
@jamasten
Compiled bicep changes
7cf99ae
@jamasten
Moved role definitions, Fixed tags & workspace names
958ff5e
@jamasten
Fixed tags
7b9873d
@jamasten
Fixed workspace names
d7a316d
@jamasten
Moved role definitions, Fixed tags & comment
2e5ab39
@jamasten
Moved role definitions; Fixed scopes, tags, & comments
8b54d1b
@jamasten
Moved role definitions
0131db4
@jamasten
Moved role definitions; Fixed tags & comments
13616ca
@jamasten
Compiled bicep changes
1d48706
@jamasten
Sorted params, Added marketplace terms deployment & dependency
072910f
@jamasten
Added missing params
f3efa46
@jamasten
Added param for session hosts deployment
7c2b5f7
@jamasten
Compiled bicep changes
805ce27
@jamasten
Added new element for security groups
0c17dd8
@jamasten
Added example of security principal, Updated property name for securi…
0a87bf2 
…ty principal
@jamasten
Compiled bicep changes
f5e27fc
@jamasten
Fixed scopes
1c9eaf2
@jamasten
Fix tags, Simplified subnet resource ID
0e0b442
@jamasten
Added resources for tagging
fa41235
@jamasten
Fixed names for app group & workspaces
61558b8
@jamasten
Fixed tags
15c65ec
@jamasten
Fixed name for app group
a870d84
@jamasten
Removed param
b46948c
@jamasten
Compiled bicep changes
ea27f83
@jamasten
Fixed app group name
e45be94
@jamasten
Added VM plan
4d43075
@jamasten jamasten added bug Something isn't working user interface bicep Related to Bicep code powershell Related to PowerShell code labels Nov 27, 2024
@jamasten jamasten requested a review from brsteel November 27, 2024 20:08
@jamasten jamasten self-assigned this Nov 27, 2024
@jamasten jamasten requested a review from a team as a code owner November 27, 2024 20:08
@jamasten jamasten linked an issue Nov 27, 2024 that may be closed by this pull request
AVD Add-On: Set marketplace terms for 3rd party images #1129
Closed
@jamasten jamasten enabled auto-merge (squash) November 27, 2024 20:11
@jamasten jamasten merged commit 57cce4d into main Nov 27, 2024
1 check passed
@jamasten jamasten deleted the 1129-avd-set-marketplace-terms branch November 27, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brsteel brsteel brsteel approved these changes

Assignees

@jamasten jamasten

Labels
bicep Related to Bicep code bug Something isn't working powershell Related to PowerShell code user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVD Add-On: Set marketplace terms for 3rd party images
2 participants
@jamasten @brsteel