-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arch detection to kubectl download #117
Conversation
Integration tests seems to be failing because of ${{ secrets.L2_REPO_TOKEN }} missing. |
To test it I created another branch in my fork kubectl-multiarch-test where I checked-in node_modules. Then I created a repo to test this here https://github.com/gtrubach/k8s-deploy-test which points to the action in that branch and tries to deploy to my local cluster. The result is here - https://github.com/gtrubach/k8s-deploy-test/runs/1999747697. It uses two self-hosted runners: Windows X64 and Raspberry Pi 2 ARM. Both successful. Please let me know if anything is needed to be fixed. |
Paging @gtrubach to address the comments, so we can take this forward 😄 |
@gtrubach one last thing left, before I merge. You have to update/add the unit test. You can find the failing test here: https://github.com/Azure/k8s-deploy/pull/117/checks?check_run_id=2088920179 |
@DS-MS - Sorry, my bad. I saw the tests failed but was confused with the red error message about token. I extended that test to run with several test cases and added another test to test that we handle 404 cases. |
Updated & added tests
This PR adds the arch detection to kubectl download using
os.arch()
call. It won't work on all arch's, but should support amd64, arm and arm64 on Linux (and some more - https://kubernetes.io/docs/setup/release/notes/#client-binaries). If the action is run on non-supported arch by kubectl it won't be able to download and will fail.Should fix #115.