Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM and other arch's support #115

Closed
gtrubach opened this issue Feb 13, 2021 · 5 comments · Fixed by #117
Closed

ARM and other arch's support #115

gtrubach opened this issue Feb 13, 2021 · 5 comments · Fixed by #117
Labels
enhancement Feature request/improved experience

Comments

@gtrubach
Copy link
Contributor

Hello,

I see in code that kubectl arch is hard-coded to amd64. Is it possible to make it download kubectl depending on agent arch? As I understand os.arch() should return correct architecture and if it used, correct kubectl will be downloaded.

@thesattiraju thesattiraju added the enhancement Feature request/improved experience label Feb 15, 2021
@azooinmyluggage
Copy link

@DS-MS Any particular reason why we stopped at amd64?

@azooinmyluggage
Copy link

Any other action which may have the same problem?

@gtrubach
Copy link
Contributor Author

I saw several, and all of them have hard-coded amd64 arch for kubectl download. For instance:

@thesattiraju
Copy link
Contributor

@azooinmyluggage @gtrubach I believe we hard-coded them to support hosted runners in the beginning. We can start supporting this, with the Self hosted runners made GA.

@gtrubach would you be willing to raise a PR for the same? 😃

@gtrubach
Copy link
Contributor Author

@DS-MS Sorry for long silence, will try to create a PR this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request/improved experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants