Update react peer deps to be >=16.8.0 <18.0.0 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBurnside
requested review from
alcail,
alkwa-msft,
allenplusplus,
anjulgarg,
mgamis-msft,
PorterNan,
prprabhu-ms and
ytyeason
as code owners
mgamis-msft
approved these changes
Jun 9, 2021
alcail
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update peer deps related to react.
To workaround an issue with peer dependencies and rush when making this change I had to set
implicitlyPreferredVersions=false(and subsequently update to have explicit peer dependencies accordingly).For more info:
Not in this PR: updating to react v17.
Why
Now we have updated to fluentui v8 (#448) we can support react 17.+
How Tested
n/a