Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Peer deps error shows up even though it is explicitly present as a dependency #1756

Open
1 of 2 tasks
ron4ex opened this issue Feb 25, 2020 · 3 comments
Open
1 of 2 tasks
Assignees

Comments

@ron4ex
Copy link
Contributor

ron4ex commented Feb 25, 2020

Is this a feature or a bug?

  • Feature
  • Bug

Please describe the actual behavior.
Here is the repo with a single package that has a few dependencies: https://github.com/ron4ex/rush-test

When I run rush update on this, why does it complain about @babel/core being not present even though it's explicitly added as a dependency?

The error is,

@rush-temp/cra > react-scripts > @svgr/webpack: @babel/[email protected] requires a peer of @babel/core@^7.0.0-0 but none was in
stalled.

But as you can see in https://github.com/ron4ex/rush-test/blob/master/apps/cra/package.json, @babel/core dependency is explicitly added.

If this is a bug, please provide the tool version, Node.js version, and OS.

  • Tool: rush
  • Tool Version: 5.20.0
  • Node Version: 10.16.3
  • OS: Ubuntu 18
@stripathix
Copy link

I too get this with

 ERROR  @vue/cli-plugin-unit-jest: [email protected] requires a peer of vue@^2.x but none was installed.

Although i have already added it

  "peerDependencies": {
    "vue": "^2.x"
  },

@briancmpbll
Copy link

I also see this issue when I have two different versions of webpack used in projects.

I have a minimal repro of this in https://github.com/briancmpbll/rush-peer-dep-repro

Without the new-webpack project, there are no peer dependency warnings. When adding the new-webpack project, I get

 WARN  [email protected] requires a peer of webpack@2 || 3 || 4 but none was installed.

even though the test-project package.json contains"webpack": "~3.10.0".

If I update the test-project package's webpack version to match that of the new-wepback project, the warning again goes away.

@mikeharder
Copy link
Contributor

Looks similar to #1415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Investigation
Development

No branches or pull requests

5 participants