Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 7752 don't allow non-param files to be selected #8521

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix 7752 don't allow non-param files to be selected #8521

merged 3 commits into from
Oct 5, 2022

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 1, 2022 •
edited
Loading

Fixes #7752

  1. only show valid params file in quickpick
  2. if invalid params file is selected e.g. browse, show error
  3. show params files in the bicep folder first (more likely to be desired)
Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford force-pushed the sw/7752-dont-deploy-params-file branch from 706794c to fef7bc6 Compare October 1, 2022 00:44
@StephenWeatherford StephenWeatherford mentioned this pull request Oct 1, 2022
Open
shenglol
shenglol approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenWeatherford StephenWeatherford merged commit f416344 into main Oct 5, 2022
@StephenWeatherford StephenWeatherford deleted the sw/7752-dont-deploy-params-file branch October 5, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow users to select a non-params file during deployment
2 participants
@StephenWeatherford @shenglol