Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow users to select a non-params file during deployment #7752

Closed
StephenWeatherford opened this issue Jul 28, 2022 · 0 comments · Fixed by #8521
Closed

Don't allow users to select a non-params file during deployment #7752

StephenWeatherford opened this issue Jul 28, 2022 · 0 comments · Fixed by #8521
Assignees
@StephenWeatherford
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request story: bicep deploy
Milestone
v0.11

Comments

@StephenWeatherford
Copy link
Contributor

Broken off from #7723

From @SetTrend:

(2) Filter Parameters Files In Deployment Process
In the process of deploying the current Bicep file's resources, only suggest json files that …

are valid
are not empty
adhere to the JSON schema for Bicep Parameters files

The ARM extension already does similar stuff. As a cheaper alternative (we do need to consider performance if there are lots of files), we should at least complain if they do pick a non-params file.
@StephenWeatherford StephenWeatherford added the enhancement New feature or request label Jul 28, 2022
@ghost ghost added the Needs: Triage 🔍 label Jul 28, 2022
@StephenWeatherford StephenWeatherford mentioned this issue Jul 28, 2022
Closed
@StephenWeatherford StephenWeatherford added devdiv Related to Bicep tooling efforts in DevDiv story: bicep deploy labels Jul 28, 2022
@ucheNkadiCode ucheNkadiCode mentioned this issue Aug 1, 2022
Closed
@alex-frankel alex-frankel added this to the v0.10 milestone Aug 3, 2022
@StephenWeatherford StephenWeatherford mentioned this issue Aug 3, 2022
Closed
@alex-frankel alex-frankel modified the milestones: v0.10, v0.11 Sep 15, 2022
@StephenWeatherford StephenWeatherford self-assigned this Sep 29, 2022
@StephenWeatherford StephenWeatherford mentioned this issue Oct 1, 2022
Merged
@StephenWeatherford StephenWeatherford moved this to Todo in Bicep Oct 1, 2022
@StephenWeatherford StephenWeatherford moved this from Todo to In Review in Bicep Oct 1, 2022
Repository owner moved this from In Review to Done in Bicep Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenWeatherford StephenWeatherford

Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request story: bicep deploy
Projects
Bicep
Archived in project
Milestone
v0.11
Development

Successfully merging a pull request may close this issue.

Fix 7752 don't allow non-param files to be selected Azure/bicep
2 participants
@StephenWeatherford @alex-frankel