-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bicep deploy - fix content modified error #6325
Conversation
TODO: Address #6283 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
93b71cf
to
73ec159
Compare
// Long-standing issue that is pretty common for all Azure calls, but can be fixed with a simple reload of VS Code. | ||
// https://github.com/microsoft/vscode-azure-account/issues/53 | ||
else if (parseError(err).message === "Entry not found in cache.") { | ||
errorMessage = `Deployment canceled for ${documentPath}. Your VS Code window must be reloaded to perform this action.`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss wording during today's meeting. I'd suggest something like:
Deployment failed for ${documentPath}. ADAL cache is out of date. Please reload VS Code and try again. If this problem persists, consider changing the VS Code setting "Azure: Authentication Library" to "MSAL".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, changing it to:
Deployment failed for ${documentPath}. Token cache is out of date. Please reload VS Code and try again. If this problem persists, consider changing the VS Code setting "Azure: Authentication Library" to "MSAL".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here:
37a05b4
Changes in this PR includes: