Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep deploy - fix content modified error #6325

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Mar 28, 2022

Changes in this PR includes:

@bhsubra bhsubra marked this pull request as draft March 28, 2022 17:06
@bhsubra bhsubra marked this pull request as ready for review March 28, 2022 19:12
@bhsubra
Copy link
Contributor Author

bhsubra commented Mar 28, 2022

TODO: Address #6283 (comment)

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

// Long-standing issue that is pretty common for all Azure calls, but can be fixed with a simple reload of VS Code.
// https://github.com/microsoft/vscode-azure-account/issues/53
else if (parseError(err).message === "Entry not found in cache.") {
errorMessage = `Deployment canceled for ${documentPath}. Your VS Code window must be reloaded to perform this action.`;
Copy link
Contributor

@StephenWeatherford StephenWeatherford Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss wording during today's meeting. I'd suggest something like:

Deployment failed for ${documentPath}. ADAL cache is out of date. Please reload VS Code and try again. If this problem persists, consider changing the VS Code setting "Azure: Authentication Library" to "MSAL".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, changing it to:
Deployment failed for ${documentPath}. Token cache is out of date. Please reload VS Code and try again. If this problem persists, consider changing the VS Code setting "Azure: Authentication Library" to "MSAL".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here:
37a05b4

@bhsubra bhsubra merged commit d0d6ff8 into main Mar 29, 2022
@bhsubra bhsubra deleted the dev/bhsubra/FixContentModifiedErr branch March 29, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants