Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExecuteTypedResponseCommandHandlerBase for BicepCreateConfigFileHandler and BicepGetRecommendedConfigLocationHandler to avoid "content modified" error #6349

Closed
StephenWeatherford opened this issue Mar 29, 2022 · 2 comments
Assignees
Labels
devdiv Related to Bicep tooling efforts in DevDiv tech debt Fixing this issue will pay down technical debt we have accumulated.
Milestone

Comments

@StephenWeatherford
Copy link
Contributor

See #6325 (comment). I've occasionally seen the "content modified" in these two commands, and they likewise shouldn't fail if content changes.

@ghost ghost added the Needs: Triage 🔍 label Mar 29, 2022
@StephenWeatherford StephenWeatherford added devdiv Related to Bicep tooling efforts in DevDiv tech debt Fixing this issue will pay down technical debt we have accumulated. and removed Needs: Triage 🔍 labels Mar 29, 2022
@StephenWeatherford StephenWeatherford changed the title Use ExecuteTypedResponseCommandHandlerBase for BicepCreateConfigFileHandler and BicepGetRecommendedConfigLocationHandler Use ExecuteTypedResponseCommandHandlerBase for BicepCreateConfigFileHandler and BicepGetRecommendedConfigLocationHandler to avoid "content modified" error Mar 29, 2022
@StephenWeatherford StephenWeatherford moved this to Todo in Bicep Apr 25, 2022
@StephenWeatherford
Copy link
Contributor Author

More common with my current changes.

@StephenWeatherford StephenWeatherford self-assigned this Apr 25, 2022
@StephenWeatherford StephenWeatherford moved this from Todo to In Progress in Bicep Apr 26, 2022
@StephenWeatherford StephenWeatherford modified the milestones: v0.6, v0.7 Apr 26, 2022
@StephenWeatherford StephenWeatherford modified the milestones: v0.7, v0.8 Jun 7, 2022
@StephenWeatherford StephenWeatherford moved this from In Progress to In Review in Bicep Jun 22, 2022
@StephenWeatherford
Copy link
Contributor Author

Fixed

Repository owner moved this from In Review to Done in Bicep Jun 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devdiv Related to Bicep tooling efforts in DevDiv tech debt Fixing this issue will pay down technical debt we have accumulated.
Projects
Archived in project
Development

No branches or pull requests

1 participant