Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docs URLs in core diagnostics #14881

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Support docs URLs in core diagnostics #14881

merged 3 commits into from
Aug 26, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 23, 2024 •
edited
Loading

Closes #14842

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 10566493939)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10566493939
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10566493939"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10566493939
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10566493939"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024 •
edited
Loading

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 35s ⏱️ - 8m 47s
11 048 tests  -     20  11 048 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 872 runs   - 12 932  25 872 ✅  - 12 932  0 💤 ±0  0 ❌ ±0 

Results for commit b51c680. ± Comparison against base commit 7c1ec1a.

♻️ This comment has been updated with latest results.

StephenWeatherford
StephenWeatherford requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to resolve the question about "core" analyzer name

@anthony-c-martin anthony-c-martin merged commit f5a2984 into main Aug 26, 2024
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/diags2 branch August 26, 2024 20:07
@anthony-c-martin anthony-c-martin mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to https://aka.ms/bicep/core-diagnostics from core compiler diagnostics
2 participants
@anthony-c-martin @StephenWeatherford