Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to https://aka.ms/bicep/core-diagnostics from core compiler diagnostics #14842

Closed
anthony-c-martin opened this issue Aug 15, 2024 · 0 comments · Fixed by #14881
Closed
Labels
Milestone

Comments

@anthony-c-martin
Copy link
Member

We now have a docs page for compiler errors!

We should link to it using the error code as an anchor in the URL:
https://aka.ms/bicep/core-diagnostics#{error_code}

E.g.:
https://aka.ms/bicep/core-diagnostics#BCP050

@anthony-c-martin anthony-c-martin added the enhancement New feature or request label Aug 15, 2024
@github-project-automation github-project-automation bot moved this to Todo in Bicep Aug 15, 2024
@stephaniezyen stephaniezyen added this to the v0.31 milestone Aug 21, 2024
anthony-c-martin added a commit that referenced this issue Aug 23, 2024
…tics (#14875)

The split class structure between `ErrorDiagnostic` & `Diagnostic` is
something I've been meaning to remove since the very early days of
Bicep. I've decided to do it now, because it'll simplify the refactor
needed for #14842.

The majority of the changes in this PR were made using refactoring
tools, not manually. The main changes I made were:
* Removed `ErrorDiagnostic`, `ErrorBuilderDelegate`,
`FixableErrorDiagnostic`
* Converted `diag is ErrorDiagnostic` type checks to use `diag.Level ==
DiagnosticLevel.Error` instead
* Renamed `ResultWithDiagnostic` to `ResultWithDiagnosticBuilder`
instead to more accurately represent its purpose
* Created `ResultWithDiagnotic<T>`, and replaced usage of `Result<T,
Diagnostic>` with it
* Other changes were mostly downstream changes of the above

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/14875)
@github-project-automation github-project-automation bot moved this from Todo to Done in Bicep Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants