Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow upgrade checker to be disabled #4208

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not .Values.disablePreUpgradeCheck }}
apiVersion: batch/v1
kind: Job
metadata:
Expand Down Expand Up @@ -25,3 +26,4 @@ spec:
requests:
cpu: 200m
memory: 256Mi
{{- end }}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not .Values.disablePreUpgradeCheck }}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
Expand All @@ -18,3 +19,4 @@ rules:
- patch
- update
- watch
{{- end }}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not .Values.disablePreUpgradeCheck }}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
Expand All @@ -14,3 +15,4 @@ subjects:
- kind: ServiceAccount
name: azureserviceoperator-pre-upgrade-checker
namespace: {{ .Release.Namespace }}
{{- end }}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not .Values.disablePreUpgradeCheck }}
apiVersion: v1
kind: ServiceAccount
metadata:
Expand All @@ -7,3 +8,4 @@ metadata:
"helm.sh/hook": pre-upgrade
"helm.sh/hook-weight": "-1"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
{{- end }}
3 changes: 3 additions & 0 deletions v2/charts/azure-service-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ azureTargetNamespaces: []
# watchers, webhooks or both.
azureOperatorMode: ""

# Opt-out for upgrade block
disablePreUpgradeCheck: false

webhook:
# webhook.port determines the port the webhook endpoint binds to.
port: 9443
Expand Down