Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow upgrade checker to be disabled #4208

Closed
wants to merge 1 commit into from

Conversation

t3mi
Copy link
Contributor

@t3mi t3mi commented Aug 22, 2024

Potentially closes #3436

What this PR does / why we need it:
The purpose of the pre-upgrade checker was to block upgrades between beta -> stable releases but in the same time it blocks upgrades between stable releases. Adding such toggle allows user to opt-out from such behaviour until it would be fully removed.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@theunrepentantgeek
Copy link
Member

Under what circumstances is the pre-upgrade-check causing upgrades to fail between stable versions?

I've just reread that code and it should not fire unless the old version in the cluster is a beta one. Is the check buggy?

I'm worried that bypassing a needed check will put the cluster into an unstable, potentially unusable, state.

@matthchr
Copy link
Member

We just don't need the check anymore (as per #3436). I think I'd rather just rip it all out though, rather than add a Helm option to disable it conditionally.

I've sent a PR to do that here: #4217

@matthchr matthchr mentioned this pull request Aug 27, 2024
1 task
@matthchr
Copy link
Member

My PR removing the upgrade check entirely has merged, so I think it makes sense to close this.

Let me know if you disagree @t3mi

@t3mi
Copy link
Contributor Author

t3mi commented Aug 28, 2024

@theunrepentantgeek we were installing the chart using terraform and for some reason it was failing at the pre-upgrade check. Unfortunately, I haven't saved the logs as we decided to use forked version of the chart w/o the check for future upgrades.

superseded by #4217

@t3mi t3mi closed this Aug 28, 2024
@t3mi t3mi deleted the helm_check_optout branch August 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove pre-upgrade check in controller
3 participants