-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy both ObjectMeta and TypeMeta when doing version conversion #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
November 17, 2021 01:02
This was referenced Nov 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 57.19% 57.23% +0.03%
==========================================
Files 422 422
Lines 85526 85624 +98
==========================================
+ Hits 48917 49007 +90
+ Misses 30371 30353 -18
- Partials 6238 6264 +26
Continue to review full report at Codecov.
|
matthchr
reviewed
Nov 17, 2021
v2/api/microsoft.authorization/v1alpha1api20200801preview/role_assignment_types_gen.go
Outdated
Show resolved
Hide resolved
theunrepentantgeek
force-pushed
the
feature/copy-objectmeta
branch
from
November 17, 2021 23:43
3e618c7
to
c430dd5
Compare
matthchr
approved these changes
Nov 17, 2021
theunrepentantgeek
force-pushed
the
feature/copy-objectmeta
branch
from
November 18, 2021 04:45
a0f7f6b
to
97bb1ed
Compare
theunrepentantgeek
force-pushed
the
feature/copy-objectmeta
branch
from
November 18, 2021 18:05
f91dc34
to
f922a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Includes embedded properties when doing intra-version conversion of resources; copying of
ObjectMeta
is required to maintain the name of the resource.Also simplifies ResourceType by removing support for arbitrary properties - we've found that we don't need it.
Resolves #1565
How does this PR make you feel: