Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make it harder to add properties to Resources? #1565

Closed
theunrepentantgeek opened this issue Jun 14, 2021 · 0 comments · Fixed by #1985
Closed

Should we make it harder to add properties to Resources? #1565

theunrepentantgeek opened this issue Jun 14, 2021 · 0 comments · Fixed by #1985
Assignees

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

In PR #1558 we added the ability for Resources to have arbitary properties, over and above the Spec and Status properties that are standard.

Adding more properties should be a rare event - we believe that it goes against the usual good-practice convensions for Kubernetes custom resources - but nothing in the code as it stands makes this difficult.

Should we add a speed-bump to encourage future maintainers (which includes ourselves) to reconsider before additional properties are included?

Describe the improvement

We could, for example, add a check that only properties of specific names are permitted - with documentation in the code about why extending the list is almost certainly not what you want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant