Delete github-codeowner-subscriber and Get-AADIdentityFromGithubUser.ps1 (#4851) #4854
Conversation
konrad-jamrozik
requested review from
a team,
sima-zhu,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
The change looks good to me. But I checked the public feed for the tool, seems we recently published the tool somewhere but no download stats after April release. I believe it is not in use anymore. It is better to check where and how we publish the tool.
Here is the public feed:
https://dev.azure.com/azure-sdk/public/_artifacts/feed/azure-sdk-for-net/NuGet/Azure.Sdk.Tools.GithubCodeownerSubscriber/overview/1.0.0-dev.20221129.1
There was a problem hiding this comment.
Found it. It released with notification configuration:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2020534&view=logs&j=787d137e-fad0-50cf-3483-4c2d26bbbecf&t=3f70e043-7ca1-58f1-879e-16481826b9a3&l=16
LGTM for the rest.
|
/check-enforcer reset |
|
Check Enforcer evaluate was requested, but there are no Azure Pipelines configured to trigger for the changed files. If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run For help using check enforcer, see https://aka.ms/azsdk/checkenforcer |
|
/check-enforcer evaluate |
|
Check Enforcer evaluate was requested, but there are no Azure Pipelines configured to trigger for the changed files. If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run For help using check enforcer, see https://aka.ms/azsdk/checkenforcer |
|
/check-enforcer override |
konrad-jamrozik
added
the
Central-EngSys
This PR addresses issue #4851
The logic from
AADIdentityFromGithubUser.ps1was moved to https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Helpers/Metadata-Helpers.ps1#L1, per this comment.