Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some unused code: GithubCodeOwnerSubscribers and Get-AADIdentityFromGithubUser.ps1 #4851

Closed
sima-zhu opened this issue Dec 1, 2022 · 3 comments · Fixed by #4854
Closed

Clean up some unused code: GithubCodeOwnerSubscribers and Get-AADIdentityFromGithubUser.ps1 #4851

sima-zhu opened this issue Dec 1, 2022 · 3 comments · Fixed by #4854
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@sima-zhu
Copy link
Contributor

sima-zhu commented Dec 1, 2022

We merged the logic of code owner subscriber and notification configuration. The tool of GithubCodeOwnerSubscribers is no longer use since then.

Specifically clean up the file: https://github.com/Azure/azure-sdk-tools/blob/main/tools/notification-configuration/github-codeowner-subscriber/Program.cs
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2022
@sima-zhu sima-zhu self-assigned this Dec 1, 2022
@sima-zhu sima-zhu added the Central-EngSys This issue is owned by the Engineering System team. label Dec 1, 2022
@azure-sdk azure-sdk moved this to 🤔Triage in Azure SDK EngSys 🤖🧠 Dec 1, 2022
@sima-zhu sima-zhu mentioned this issue Dec 1, 2022
Merged
@sima-zhu sima-zhu changed the title Clean up the tool GithubCodeOwnerSubscribers code Clean up the unused code Dec 1, 2022
@sima-zhu sima-zhu removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2022
@sima-zhu sima-zhu removed their assignment Dec 1, 2022
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Dec 1, 2022

Identified another place to clean up.
https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Get-AADIdentityFromGithubUser.ps1

@sima-zhu sima-zhu mentioned this issue Dec 1, 2022
Merged
@konrad-jamrozik konrad-jamrozik mentioned this issue Dec 1, 2022
Merged
@konrad-jamrozik konrad-jamrozik self-assigned this Dec 1, 2022
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Dec 1, 2022

@konrad-jamrozik Thanks for taking care of this issue! 👍

konrad-jamrozik pushed a commit that referenced this issue Dec 2, 2022
Delete github-codeowner-subscriber and Get-AADIdentityFromGithubUser.…
063689a 
…ps1 (#4851) (#4854)

This PR addresses issue #4851 

The logic from `AADIdentityFromGithubUser.ps1` was moved to https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Helpers/Metadata-Helpers.ps1#L1, per [this comment](#4835 (comment)).
@konrad-jamrozik konrad-jamrozik linked a pull request Dec 2, 2022 that will close this issue
Delete github-codeowner-subscriber and Get-AADIdentityFromGithubUser.ps1 (#4851) #4854
Merged
@konrad-jamrozik konrad-jamrozik moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🤖🧠 Dec 2, 2022
@konrad-jamrozik konrad-jamrozik changed the title Clean up the unused code Clean up some unused code: GithubCodeOwnerSubscribers and Get-AADIdentityFromGithubUser.ps1 Dec 2, 2022
@konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik Thanks for taking care of this issue! 👍

@sima-zhu Happy to help! :)

@konrad-jamrozik konrad-jamrozik mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
2 participants
@konrad-jamrozik @sima-zhu