Removes more timeout from storage operation builders #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple PRs landing one on top of each other, not all of the timeouts as part of the bulider patterns were removed during #893.
These remove all but two that use the Storage crate, both in
data_tables
.setters
, but instead provides it's own builder methods to enable adding multiple database operations into the single transaction. It does not need thesetters
portion of the operation macro, but should still be a builder.In both of these cases, removing the
timeout
option from the operation causes the macro to fail, as it requires at least one optional parameter.With TransactionBuilder, I'd prefer the macro be updated to support no optional params if we're providing our own setters.
With UpdateOrMergeEntityBuilder, this probably doesn't need to be an operation, however it's the only operation that doesn't need .into_future, which makes it feel weird from a user's perspective. Once IntoFuture is stable, this could just return a future directly without using the builder pattern.