Timeout policy #893
Merged
Timeout policy #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
approved these changes
Jul 5, 2022
yoshuawuyts
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
I think this is a good change insofar that it moves the timeout logic from the specific endpoints to a generalized middleware.
I don't particularly like that this then requires constructing a context object manually which needs to be passed. But that's the design we currently have, and I'm happy to do the work to streamline that part of it.
Either way, keen to have this merged!
bmc-msft
pushed a commit
to bmc-msft/azure-sdk-for-rust
that referenced
this pull request
Jul 11, 2022
With multiple PRs landing one on top of each other, not all of the timeouts as part of the bulider patterns were removed during Azure#893. These remove all but two that use the Storage crate, both in `data_tables`. 1. TransactionBuilder. This Builder does not use `setters`, but instead provides it's own builder methods to enable adding multiple database operations into the single transaction. It does not need the `setters` portion of the operation macro, but should still be a builder. 2. UpdateOrMergeEntityBuilder. This no longer needs to be a builder, as the only optional field is now handled via aforementioned PR.
rylev
pushed a commit
that referenced
this pull request
Jul 11, 2022
With multiple PRs landing one on top of each other, not all of the timeouts as part of the bulider patterns were removed during #893. These remove all but two that use the Storage crate, both in `data_tables`. 1. TransactionBuilder. This Builder does not use `setters`, but instead provides it's own builder methods to enable adding multiple database operations into the single transaction. It does not need the `setters` portion of the operation macro, but should still be a builder. 2. UpdateOrMergeEntityBuilder. This no longer needs to be a builder, as the only optional field is now handled via aforementioned PR. Co-authored-by: Brian Caswell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a timeout policy to storage clients.
Now the user can use the
contextoption to specify timeouts as well as set a default timeout for all operations.Note: the experience for actually setting a timeout is somewhat worse, but this is because the context API is a bit awkward. That needs to be improved independent of this change.