Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Vault Certificate Delete #1177

Merged
merged 2 commits into from
Dec 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions sdk/security_keyvault/src/certificates/operations/delete.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
use crate::prelude::*;
use azure_core::{headers::Headers, CollectedResponse, Method};

operation! {
DeleteCertificate,
client: CertificateClient,
name: String,
}

impl DeleteCertificateBuilder {
pub fn into_future(mut self) -> DeleteCertificate {
Box::pin(async move {
let mut uri = self.client.keyvault_client.vault_url.clone();
uri.set_path(&format!("certificates/{}", self.name));

let headers = Headers::new();
let mut request =
self.client
.keyvault_client
.finalize_request(uri, Method::Delete, headers, None)?;

let response = self
.client
.keyvault_client
.send(&mut self.context, &mut request)
.await?;

let response = CollectedResponse::from_response(response).await?;
let body = response.body();
let response = serde_json::from_slice::<KeyVaultGetCertificateResponse>(body)?;
Ok(response)
})
}
}

type DeleteCertificateResponse = KeyVaultGetCertificateResponse;
2 changes: 2 additions & 0 deletions sdk/security_keyvault/src/certificates/operations/mod.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
mod backup;
mod create;
mod delete;
mod get_certificate;
mod get_versions;
mod import;
mod merge;
mod update_properties;
pub use backup::*;
pub use create::*;
pub use delete::*;
pub use get_certificate::*;
pub use get_versions::*;
pub use import::*;
Expand Down
13 changes: 2 additions & 11 deletions sdk/security_keyvault/src/clients/certificate_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,11 @@ impl CertificateClient {
///
/// Runtime::new().unwrap().block_on(example());
/// ```
pub async fn delete<N>(&self, name: N) -> azure_core::Result<()>
pub fn delete<N>(&self, name: N) -> DeleteCertificateBuilder
where
N: Into<String>,
{
// let mut uri = self.vault_url.clone();
// uri.set_path(&format!("certificates/{}", certificate_name));

// self.delete_authed(uri.to_string()).await?;

// Ok(())

let _name = name.into();

todo!("See issue #174 at: https://github.com/Azure/azure-sdk-for-rust/issues/174.")
DeleteCertificateBuilder::new(self.clone(), name.into())
}

/// Lists all the certificates in the Key Vault.
Expand Down