Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Vault Certificate Delete #1177

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Key Vault Certificate Delete #1177

merged 2 commits into from
Dec 16, 2022

Conversation

daniel-larsen
Copy link
Contributor

Adds Key Vault certificate delete operation. Noticed that there was a placeholder for delete which mentions issue 174.

todo!("See issue #174 at: https://github.com/Azure/azure-sdk-for-rust/issues/174.")

Issue 174 talks about long running operations. As far as I can tell from the API docs certificate deletion is not a long running operation. I tested it on my computer and delete took less time to return than a Get.

@demoray
Copy link
Contributor

demoray commented Dec 15, 2022

The issues that are breaking this pr are addressed in #1178

@demoray
Copy link
Contributor

demoray commented Dec 16, 2022

@daniel-larsen can you rebase this PR?

@demoray demoray merged commit 6cc519e into Azure:main Dec 16, 2022
@daniel-larsen daniel-larsen deleted the security-keyvault-certificate-delete branch December 16, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants