This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Add support to sas authorization #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change createWrapService to static method and reference it by self to avoid non object context error
- Fix $this in non object context error
- Added getNamespace method to return private _namespace property - Changed getFilter comments
|
|
Shaked
approved these changes
Nov 22, 2017
brendanmurty
approved these changes
Nov 23, 2017
sergey-shandar
approved these changes
Nov 27, 2017
This was referenced Nov 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggy backing off @Shaked original Pull request. Made the required changes to get it running on our specific environment.
Main change was revolved around running composer update to revert the doctrine packages that require php >=7.
Also changed createWrapService to a static method to avoid a fatal "$this in non object context" error.