This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Add support to SAS authorization #956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can one of the admins verify this patch? |
sergey-shandar
suggested changes
Oct 9, 2017
|
@Shaked thank you for the PR. |
|
@sergey-shandar np. It should be quite easy to support php5.6 and 7.0. FYI php5.6 is not supported anymore: http://php.net/supported-versions.php (only security updates) |
|
@Shaked yes, I've seen the table. According to this table, we may consider to drop 5.6 in 2019 :-) |
|
Closed as a duplicate of #958 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support using SAS authorization.
As mentioned in #726 (comment) I haven't followed the contribution guidelines but am opening a pull request in case someone wants to help with that.
As far as I understand, Wrap authentication is deprecated so I haven't put effort in changing it to show more correct error messages (for example, I could have split
ServiceBusSettings.phpso that it will throw the correct error when using the wrong connectionString keys.Shaked