Azure Redis .Net SDK update for new api v2023-08-01 #39230

koderjoker · 2023-10-12T19:33:56Z

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json

For specific information about pull request etiquette and best practices, see this section.

github-actions · 2023-10-12T19:34:21Z

Thank you for your contribution @koderjoker! We will review the pull request and get back to you soon.

pallavit · 2023-10-12T21:27:23Z

@koderjoker this PR is getting tagged as a community contribution. Please review the Azure SDK onboarding documentation and ensure that your GitHub organization membership and permissions are correct.

Azure SDK onboarding (Microsoft internal)
Azure SDK onboarding assistance (Microsoft internal)

/cc: @ArthurMa1978. Also please ensure you have the correct aliases are added to the code owners file - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS

koderjoker · 2023-10-13T06:39:08Z

@pallavit submitted request for Azure SDK Partners. No new names to add to Code Owners from our side

azure-sdk · 2023-10-13T10:59:47Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Redis

- Adds test resource json file - Creates FTs for new flush operation - Updates assets.json after pushing new session records

Adds functional tests for aad

koderjoker · 2023-11-21T15:38:06Z

Test recording for all tests, for new API version in progress, will push session records and update assets.json once complete

* Update Channel Tests * Update correct data type

koderjoker · 2023-11-29T19:37:28Z

Recordings updated for latest api version as part of https://github.com/Azure/azure-sdk-assets/releases/tag/net%2Fredis%2FAzure.ResourceManager.Redis_50c384bcc2

jsquire

@koderjoker: You are still coming up as having none of the public organizations required nor write permissions in the repository. Please review the Azure SDK onboarding guide.
This will need to be corrected before this PR can move forward.

koderjoker · 2023-11-30T07:51:49Z

@jsquire I'm already a part of Azure GitHub and Azure SDK partners. Applied for write permissions for Azure cache for Redis SDKs.

jsquire · 2023-11-30T14:46:07Z

@jsquire I'm already a part of Azure GitHub and Azure SDK partners. Applied for write permissions for Azure cache for Redis SDKs.

These organization memberships must be public on your profile and you must have write permissions to the Azure SDK repository. Your memberships are private and you lack write permissions. Please refer to the onboarding guide for further context.

koderjoker · 2023-12-02T04:12:43Z

@jsquire thanks, I've ensured that I have the correct permissions now

koderjoker · 2023-12-02T05:29:26Z

Hi @archerzz @jsquire @tg-msft @KrzysztofCwalina @ArcturusZhang @pallavit @ArthurMa1978 @live1206! Who would be the assigned reviewer for this PR?

Despite the PR having the latest code generated and recordings for 2023-08-01 https://github.com/Azure/azure-sdk-assets/releases/tag/net%2Fredis%2FAzure.ResourceManager.Redis_50c384bcc2, the pipeline is showing errors regarding both

archerzz · 2023-12-04T06:02:17Z

Hi @archerzz @jsquire @tg-msft @KrzysztofCwalina @ArcturusZhang @pallavit @ArthurMa1978 @live1206! Who would be the assigned reviewer for this PR?

Despite the PR having the latest code generated and recordings for 2023-08-01 Azure/azure-sdk-assets@net%2Fredis%2FAzure.ResourceManager.Redis_50c384bcc2 (release), the pipeline is showing errors regarding both

@koderjoker I think the error message is quite clear:

Generated code is not up to date.
    You may need to rebase on the latest main, 
    run 'eng\scripts\Update-Snippets.ps1' if you modified sample snippets or other *.md files (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#updating-sample-snippets), 
    run 'eng\scripts\Export-API.ps1' if you changed public APIs (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#public-api-additions). 
    run 'dotnet build /t:GenerateCode' to update the generated code and samples.
    
To reproduce this error locally, run 'eng\scripts\CodeChecks.ps1 -ServiceDirectory redis'.

archerzz · 2023-12-04T06:02:31Z

Besides, looks like you have some test recordings which need update.

sdk/redis/Azure.ResourceManager.Redis/src/Generated/RedisCacheAccessPolicyAssignmentData.cs

sdk/redis/Azure.ResourceManager.Redis/src/Generated/Models/RedisCommonConfiguration.cs

koderjoker · 2023-12-04T10:04:37Z

Hi @archerzz @jsquire @tg-msft @KrzysztofCwalina @ArcturusZhang @pallavit @ArthurMa1978 @live1206! Who would be the assigned reviewer for this PR?
Despite the PR having the latest code generated and recordings for 2023-08-01 Azure/azure-sdk-assets@net%2Fredis%2FAzure.ResourceManager.Redis_50c384bcc2 (release), the pipeline is showing errors regarding both

@koderjoker I think the error message is quite clear:
Generated code is not up to date.
    You may need to rebase on the latest main, 
    run 'eng\scripts\Update-Snippets.ps1' if you modified sample snippets or other *.md files (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#updating-sample-snippets), 
    run 'eng\scripts\Export-API.ps1' if you changed public APIs (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#public-api-additions). 
    run 'dotnet build /t:GenerateCode' to update the generated code and samples.
    
To reproduce this error locally, run 'eng\scripts\CodeChecks.ps1 -ServiceDirectory redis'.

@archerzz running eng\scripts\CodeChecks.ps1 -ServiceDirectory redis as mentioned in the error, on our local gives us 0 errors.

No new code is generated when eng\scripts\Export-API.ps1 or dotnet build /t:GenerateCode are run, and no snippets on running eng\scripts\Update-Snippets.ps1

Are there any steps we could take to see what is left to be generated, and unblock ourselves on this issue?

koderjoker · 2023-12-04T10:22:25Z

Besides, looks like you have some test recordings which need update.

Test recordings have already been recorded for this api version, for all the older and new tests (2023-08-01) https://github.com/Azure/azure-sdk-assets/tree/net/redis/Azure.ResourceManager.Redis_50c384bcc2/net/sdk/redis/Azure.ResourceManager.Redis/tests/SessionRecords, and assets.json updated.

Unable to find a record for the request PUT https://management.azure.com/subscriptions/3f43c5ac-2f70-4e2c-87ff-9a6822cbc0dc/resourcegroups/testRG-1352?api-version=2022-09-01
And this resource group request uri doesn't exist in any of our recordings. Is it not picking up the latest recordings? All tests are failing with this error.

Have we missed out on configuring or uploading any file, to cause this issue?

jsquire · 2023-12-04T14:25:02Z

@jsquire thanks, I've ensured that I have the correct permissions now

You still do not have a public Microsoft organization membership. Please correct.

koderjoker · 2023-12-05T04:18:27Z

@jsquire corrected as requested, sorry for the confusion

jsquire · 2023-12-05T15:23:51Z

koderjoker

Thanks. Confirmed that we're looking good. Removing my block. Please work with Arthur and team on the code review.

Issues have been corrected.

koderjoker · 2023-12-13T10:01:18Z

Updated session records: https://github.com/Azure/azure-sdk-assets/tree/net/redis/Azure.ResourceManager.Redis_73d38d0d17/net/sdk/redis/Azure.ResourceManager.Redis/tests/SessionRecords

archerzz

@koderjoker LGTM.

By the way, if you are going to release a new version, don't forget to update CHANGELOG.md. See here for details.

Kanchan Joshi added 4 commits October 13, 2023 00:03

Update autorest.md file with latest swagger and allow model duplication

08c3a0c

Generate and upgrade sdk code

ede4f4a

Customize redis common configuration code to include aad-enabled

f8ecd50

Regenerate API file

ae80c1a

github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 12, 2023

Customize redis common configuration code to include aad-enabled

59be78e

Mitigate breaking change

32a0110

austintolani and others added 7 commits October 18, 2023 09:22

Create empty test-resources.json

c39fe47

Create FlushFunctionalTests.cs

7a5d75b

Update assets.json

9b83baf

Merge pull request #1 from austintolani/kj/dotNet_2023-08-01

c6c482d

- Adds test resource json file - Creates FTs for new flush operation - Updates assets.json after pushing new session records

Add functional tests for aad (#2)

a775ff0

Adds functional tests for aad

Update Channel Tests (#3)

6f18399

Merge main

cb1d4d1

koderjoker marked this pull request as ready for review November 21, 2023 15:36

koderjoker requested review from KrzysztofCwalina, tg-msft, archerzz, ArcturusZhang, ArthurMa1978, pallavit and jsquire as code owners November 21, 2023 15:36

openapi-assignment-bot bot assigned live1206 Nov 21, 2023

Oscarba/fix (#4)

71d2692

* Update Channel Tests * Update correct data type

jsquire previously requested changes Nov 29, 2023

View reviewed changes

Azure deleted a comment from azure-pipelines bot Dec 2, 2023

archerzz requested changes Dec 4, 2023

View reviewed changes

sdk/redis/Azure.ResourceManager.Redis/src/Generated/RedisCacheAccessPolicyAssignmentData.cs Outdated Show resolved Hide resolved

sdk/redis/Azure.ResourceManager.Redis/src/Generated/Models/RedisCommonConfiguration.cs Outdated Show resolved Hide resolved

Kanchan Joshi added 6 commits December 9, 2023 13:29

Address reviewer comments

cab727a

Merge branch 'main' into kj/dotNet_2023-08-01

30e9774

Update generatred code after mergin in main

3ae03d5

Update FTs for updated models

f6282fe

Update AAD FT

92a1359

Update assets.json

563cb62

koderjoker requested a review from archerzz December 13, 2023 11:13

archerzz approved these changes Dec 14, 2023

View reviewed changes

Update changelog

834a1e0

archerzz approved these changes Dec 15, 2023

View reviewed changes

archerzz merged commit da78e04 into Azure:main Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Redis .Net SDK update for new api v2023-08-01 #39230

Azure Redis .Net SDK update for new api v2023-08-01 #39230

koderjoker commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

pallavit commented Oct 12, 2023

koderjoker commented Oct 13, 2023 •

edited

Loading

azure-sdk commented Oct 13, 2023 •

edited

Loading

koderjoker commented Nov 21, 2023 •

edited

Loading

koderjoker commented Nov 29, 2023 •

edited

Loading

jsquire left a comment

koderjoker commented Nov 30, 2023

jsquire commented Nov 30, 2023

koderjoker commented Dec 2, 2023

koderjoker commented Dec 2, 2023

archerzz commented Dec 4, 2023

archerzz commented Dec 4, 2023

koderjoker commented Dec 4, 2023 •

edited

Loading

koderjoker commented Dec 4, 2023 •

edited

Loading

jsquire commented Dec 4, 2023

koderjoker commented Dec 5, 2023 •

edited

Loading

jsquire commented Dec 5, 2023

koderjoker commented Dec 13, 2023

archerzz left a comment

Azure Redis .Net SDK update for new api v2023-08-01 #39230

Azure Redis .Net SDK update for new api v2023-08-01 #39230

Conversation

koderjoker commented Oct 12, 2023

Contributing to the Azure SDK

github-actions bot commented Oct 12, 2023

pallavit commented Oct 12, 2023

koderjoker commented Oct 13, 2023 • edited Loading

azure-sdk commented Oct 13, 2023 • edited Loading

koderjoker commented Nov 21, 2023 • edited Loading

koderjoker commented Nov 29, 2023 • edited Loading

jsquire left a comment

Choose a reason for hiding this comment

koderjoker commented Nov 30, 2023

jsquire commented Nov 30, 2023

koderjoker commented Dec 2, 2023

koderjoker commented Dec 2, 2023

archerzz commented Dec 4, 2023

archerzz commented Dec 4, 2023

koderjoker commented Dec 4, 2023 • edited Loading

koderjoker commented Dec 4, 2023 • edited Loading

jsquire commented Dec 4, 2023

koderjoker commented Dec 5, 2023 • edited Loading

jsquire commented Dec 5, 2023

koderjoker commented Dec 13, 2023

archerzz left a comment

Choose a reason for hiding this comment

koderjoker commented Oct 13, 2023 •

edited

Loading

azure-sdk commented Oct 13, 2023 •

edited

Loading

koderjoker commented Nov 21, 2023 •

edited

Loading

koderjoker commented Nov 29, 2023 •

edited

Loading

koderjoker commented Dec 4, 2023 •

edited

Loading

koderjoker commented Dec 4, 2023 •

edited

Loading

koderjoker commented Dec 5, 2023 •

edited

Loading