[CODEOWNERS] Fix issue where api review file owner rule not mat… #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems working |
jeremymeng
force-pushed
the
api-review-owner
branch
from
63359f9 to
bbf9015
Compare
jeremymeng
changed the title
|
Thank you for fixing this! |
ramya-rao-a
approved these changes
Oct 29, 2019
Last rule wins, so specific library directory owners override the api review file owner. Fixing it by move the api review rule after sdk rules.
jeremymeng
force-pushed
the
api-review-owner
branch
from
bbf9015 to
477b763
Compare
jeremymeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precedence is that last rule wins, so specific library directory
owners override the api review file owner. Fixing it by move the api
review rule after sdk rules.