Skip to content

Commit

Permalink
[CODEOWNERS] Fix issue where api review file owner rule not matched
Browse files Browse the repository at this point in the history
Last rule wins, so specific library directory owners override the api
review file owner. Fixing it by move the api review rule after sdk
rules.
  • Loading branch information
jeremymeng committed Nov 25, 2019
1 parent e598c92 commit 477b763
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
# Catch all
/sdk/ @ramya-rao-a

# API review files
/sdk/**/review/*api.md @bterlson

# Core
/sdk/core/abort-controller/ @chradek
/sdk/core/core-amqp/ @ramya-rao-a @chradek
Expand All @@ -36,6 +33,9 @@

/sdk/test-utils/ @HarshaNalluru

# API review files
/sdk/**/review/*api.md @bterlson

# Management Plane
/**/*Management*.ts @qiaozha
/**/arm-*/ @qiaozha
Expand Down

0 comments on commit 477b763

Please sign in to comment.