Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Backup Support for SQL Server in Azure VM" #8499

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Revert "Backup Support for SQL Server in Azure VM" #8499

merged 1 commit into from
Feb 13, 2019

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Feb 7, 2019

Reverts #8349

@markcowl
Copy link
Member Author

markcowl commented Feb 7, 2019

Need updates to the cmdlets - specifically we cannot release 'preview
functionality as part of the main Az release.

Also, some of the newly unskipped tests are failing on some platforms

@siddharth7
Copy link
Contributor

From preview, I meant, this won't be the final release for this workload. Some additions and client side validation are to be made after updating the SDK version.
Can you point me to the failing tests?

@vladimir-shcherbakov
Copy link
Contributor

here is the link to the failing test: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4159&view=logs&jobId=5264e576-3c6f-51f6-f055-fab409685f20&taskId=11b6e5a1-913e-50ac-35c6-54672a9d99ea&lineStart=1753&lineEnd=1753&colStart=29&colEnd=30

siddharth7
siddharth7 reviewed Feb 11, 2019
View reviewed changes
src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.cs
@@ -75,7 +90,11 @@ public void TestAzureVMFullRestore()
_logger, PsBackupProviderTypes.IaasVm, "Test-AzureVMFullRestore");
}

#if NETSTANDARD
[Fact(Skip = "Needs investigation, TestManagementClientHelper class wasn't initialized with the ResourceManagementClient client.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test that is failing for a particular platform was marked to be skipped in a PR by @MiYanni (https://github.com/Azure/azure-powershell/pull/7497/files#diff-5ac3bb75515258487eb34f862e7890dd) which I removed in this PR. Moreover, it looks like a platform issue which was solved later in dotnet core 2.1 (https://stackoverflow.com/questions/48719442/dotnet-core-2-0-on-macos-gets-libcurl-and-ssl-error-triggered-by-httpclient-when)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl We should discuss running tests as netcore 2.1 instead of 2.0, sooner rather than later. I'm sure there are other fixes like this one above.

@vladimir-shcherbakov
Copy link
Contributor

@siddharth7 We can't merge the PR until the Disable-AzRecoveryServicesBackupAutoProtection cmdlet gets implemented and test coverage is provided including piping scenarios.

@MiYanni MiYanni mentioned this pull request Feb 12, 2019
Merged
@siddharth7
Copy link
Contributor

#8529
This PR contains the SDK update, remaining cmdlet and piping scenario tests

vladimir-shcherbakov
vladimir-shcherbakov approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@vladimir-shcherbakov vladimir-shcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging to complete the revert process

@vladimir-shcherbakov vladimir-shcherbakov merged commit e766f60 into master Feb 13, 2019
siddharth7 added a commit to MabOneSdk/azure-powershell that referenced this pull request Feb 14, 2019
@siddharth7
Revert "Merge pull request Azure#8499 from Azure/revert-8349-mercury_…
00f2c6f 
…dev_test"

This reverts commit e766f60, reversing
changes made to 8c3b2d1.
@cormacpayne cormacpayne deleted the revert-8349-mercury_dev_test branch February 19, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth7 siddharth7 siddharth7 left review comments

@MiYanni MiYanni MiYanni left review comments

@vladimir-shcherbakov vladimir-shcherbakov vladimir-shcherbakov approved these changes

Assignees

@siddharth7 siddharth7

Labels
Do Not Merge 🚫 needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markcowl @siddharth7 @vladimir-shcherbakov @MiYanni @azuresdkci