Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup Support for SQL Server in Azure VM #8349

Merged
merged 10 commits into from
Feb 7, 2019
Merged

Backup Support for SQL Server in Azure VM #8349

merged 10 commits into from
Feb 7, 2019

Conversation

siddharth7
Copy link
Contributor

@siddharth7 siddharth7 commented Jan 18, 2019 •
edited
Loading

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/203

Checklist

@siddharth7 siddharth7 force-pushed the mercury_dev_test branch 5 times, most recently from ec2e66a to cba2348 Compare January 21, 2019 12:03
@MiYanni
Copy link
Contributor

MiYanni commented Jan 23, 2019

@siddharth7 You have static analysis failures.

@maddieclayton maddieclayton assigned MiYanni and unassigned siddharth7 Jan 23, 2019
@siddharth7 siddharth7 force-pushed the mercury_dev_test branch 3 times, most recently from d966c61 to f2dffd4 Compare January 28, 2019 13:16
@MiYanni
Copy link
Contributor

MiYanni commented Jan 31, 2019

@vladimir-shcherbakov Please reassign to someone else. Thanks.

@MiYanni MiYanni removed their assignment Jan 31, 2019
@siddharth7 siddharth7 force-pushed the mercury_dev_test branch 2 times, most recently from 798f26e to b7ffeb0 Compare February 1, 2019 10:43
@vladimir-shcherbakov vladimir-shcherbakov self-assigned this Feb 1, 2019
@vladimir-shcherbakov
Copy link
Contributor

@siddharth7 @MiYanni Could you please point me to the final version of the design review (PowerShell-help style syntax descriptions of all new and changed cmdlets)?

@siddharth7
Copy link
Contributor Author

@vladimir-shcherbakov https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/203

vladimir-shcherbakov
vladimir-shcherbakov suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@vladimir-shcherbakov vladimir-shcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I can't find implementation of the Disable-AzRecoveryServicesBackupAutoProtection cmdlet
  • Could you also add test-cases for all new cmdlets including piping scenarios?

@siddharth7
Copy link
Contributor Author

@vladimir-shcherbakov

  1. The implementation of Disable-AutoProtection has a dependency on newer version of SDK which was published yesterday. We need to test the new sdk before updating SDK version in our module.
  2. All the new cmdlets do have the tests except Enable-AutoProtection. Writing a test for it requires Disable-AutoProtection too. But the cmdlet has been tested by the team as of now.
  3. This is more of a preview release as of now where we want to get basic functionality out. SDK update and piping scenarios will be taken up in the next release.

@vladimir-shcherbakov
Copy link
Contributor

signing: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/142/

@vladimir-shcherbakov vladimir-shcherbakov merged commit 751c9bb into Azure:master Feb 7, 2019
@markcowl markcowl mentioned this pull request Feb 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-shcherbakov vladimir-shcherbakov vladimir-shcherbakov approved these changes

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siddharth7 @MiYanni @vladimir-shcherbakov @azuresdkci @maddieclayton