Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL Binding support #124

Merged
merged 18 commits into from
May 4, 2022
Merged

Conversation

Charles-Gagnon
Copy link
Contributor

Adds Python language support for SQL Input/Output bindings

https://github.com/Azure/azure-functions-sql-extension

(this is a continuation of #118 - that one can be closed)

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #124 (eabe1b7) into dev (18c50cc) will increase coverage by 0.21%.
The diff coverage is 93.50%.

@@            Coverage Diff             @@
##              dev     #124      +/-   ##
==========================================
+ Coverage   85.64%   85.85%   +0.21%     
==========================================
  Files          47       49       +2     
  Lines        2786     2863      +77     
  Branches      374      388      +14     
==========================================
+ Hits         2386     2458      +72     
- Misses        324      329       +5     
  Partials       76       76              
Flag Coverage Δ
unittests 85.85% <93.50%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/_abc.py 75.76% <75.00%> (-0.06%) ⬇️
azure/functions/__init__.py 100.00% <100.00%> (ø)
azure/functions/_sql.py 100.00% <100.00%> (ø)
azure/functions/sql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c50cc...eabe1b7. Read the comment docs.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please add a NoQA flag on the code lines in the abstract class which cannot be covered.

azure/functions/_abc.py Show resolved Hide resolved
@vrdmr vrdmr merged commit 6f10a44 into Azure:dev May 4, 2022
@Charles-Gagnon Charles-Gagnon deleted the luczhan/sqlbindings branch May 5, 2022 00:00
YunchuWang pushed a commit that referenced this pull request May 11, 2022
YunchuWang added a commit that referenced this pull request May 11, 2022
This reverts commit 6f10a44.

Co-authored-by: peterstone2017 <[email protected]>
gavin-aguiar added a commit that referenced this pull request May 16, 2022
gavin-aguiar added a commit that referenced this pull request May 16, 2022
gavin-aguiar added a commit that referenced this pull request Sep 22, 2022
gavin-aguiar added a commit that referenced this pull request Oct 10, 2022
gavin-aguiar added a commit that referenced this pull request Oct 21, 2022
gavin-aguiar added a commit that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants