Add SQL Bindings #118
Closed
Add SQL Bindings #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
vrdmr,
gavin-aguiar and
YunchuWang
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #118 +/- ##
==========================================
- Coverage 85.64% 85.43% -0.21%
==========================================
Files 47 49 +2
Lines 2786 2863 +77
Branches 374 388 +14
==========================================
+ Hits 2386 2446 +60
- Misses 324 341 +17
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
YunchuWang
reviewed
Apr 21, 2022
YunchuWang
reviewed
Apr 21, 2022
| def to_json(self) -> str: | ||
| """Return the JSON representation of the SqlRow""" | ||
| return json.dumps(dict(self)) | ||
|
|
There was a problem hiding this comment.
can we add tests to address codecov warnings?
|
can we add description for this PR? |
gavin-aguiar
reviewed
May 2, 2022
| data.append(row) | ||
|
|
||
| else: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Add a message with the NotImplementedError
Merged
|
@YunchuWang @vrdmr @gavin-aguiar This can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.