-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for dotnet-isolated function app debugging hang issue #8596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages meant for tooling as core tools rely on that prefix.
liliankasem
approved these changes
Aug 2, 2022
satvu
approved these changes
Aug 2, 2022
kshyju
added a commit
that referenced
this pull request
Aug 2, 2022
* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix. * Test improvements * Added release notes
kshyju
added a commit
that referenced
this pull request
Aug 2, 2022
* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix. * Test improvements * Added release notes
kshyju
added a commit
that referenced
this pull request
Aug 3, 2022
…ped up version to 4.9.2 Fix for dotnet-isolated function app debugging hang issue (#8596) * Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix. * Test improvements * Added release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to fix the bug introduced in #8435
Context:
In #8435, I added code to log the tooling log messages using a new logger for which the log level is always set to Informational. My PR had a bug where I was stripping out the special prefix(
azfuncjsonlog:
)of the log messages before sending it to the logger. This caused core-tools to not handle this messages properly.Impact of this bug:
Visual studio debugging for dotnet-isolated functions apps will hang.
Fix:
In this PR, I deleted the code which stripped the prefix so that the message is sent as it is to the logger. Now coretools will handle messages with this prefix as expected.
Pull request checklist
release_notes.md
Validation