Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dotnet-isolated function app debugging hang issue #8596

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Aug 2, 2022

This is a follow up PR to fix the bug introduced in #8435

Context:
In #8435, I added code to log the tooling log messages using a new logger for which the log level is always set to Informational. My PR had a bug where I was stripping out the special prefix(azfuncjsonlog:)of the log messages before sending it to the logger. This caused core-tools to not handle this messages properly.

Impact of this bug:
Visual studio debugging for dotnet-isolated functions apps will hang.

Fix:
In this PR, I deleted the code which stripped the prefix so that the message is sent as it is to the logger. Now coretools will handle messages with this prefix as expected.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Validation

  1. Created a new version of "Microsoft.Azure.WebJobs.Script.WebHost" nuget package with the host changes.
  2. Consumed that nuget version in CoreTools (Azure.Functions.CLI)
  3. Copied the build output of the Azure.Functions.CLI project and replaced it in the "cli_x64" of the release used by VS in local computer.
  4. Verified debugging works.
  5. Also verified the temporary file which VS uses (to which Coretools will write the message which include the process id).

@kshyju kshyju merged commit 29fcb5a into dev Aug 2, 2022
@kshyju kshyju deleted the shkr/console_logging_from_worker_fix branch August 2, 2022 20:10
kshyju added a commit that referenced this pull request Aug 2, 2022
* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix.

* Test improvements

* Added release notes
kshyju added a commit that referenced this pull request Aug 2, 2022
)

* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix.

* Test improvements

* Added release notes
kshyju added a commit that referenced this pull request Aug 2, 2022
* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix.

* Test improvements

* Added release notes
kshyju added a commit that referenced this pull request Aug 3, 2022
#8599)

* Fix for dotnet-isolated function app debugging hang issue (#8596)

* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix.

* Test improvements

* Added release notes

* Bump version to 481

* Fixed release notes
kshyju added a commit that referenced this pull request Aug 3, 2022
…ped up version to 4.9.2

Fix for dotnet-isolated function app debugging hang issue (#8596)

* Deleted the code which removed the "azfuncjsonlog:" prefix for log messages meant for tooling as core tools rely on that prefix.

* Test improvements

* Added release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants