Adding a new logger for tooling console log entries from language workers so that they are always logged as Informational #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via standard output (Console.WriteLine) with Information level as the logging level so that the logging level set for Host is not affecting these log entries as they are being used by debuggers/IDEs
kshyju
requested review from
brettsam,
fabiocav,
liliankasem,
kashimiz,
soninaren,
madelinegordon,
surgupta-msft and
satvu
satvu
approved these changes
Jun 3, 2022
kshyju
commented
Jun 3, 2022
| } | ||
|
|
||
| internal WorkerConsoleLogService(ILogger logger, IWorkerConsoleLogSource consoleLogSource) | ||
| internal WorkerConsoleLogService(ILogger logger, Lazy<ILogger> toolingConsoleJsonLoggerLazy, IWorkerConsoleLogSource consoleLogSource) |
There was a problem hiding this comment.
This constructor is being used by UTs to inject test version of dependencies.
madelinegordon
approved these changes
Jun 6, 2022
liliankasem
approved these changes
Jun 6, 2022
kshyju
commented
Jun 7, 2022
| @@ -49,7 +49,7 @@ public ILogger CreateLogger(string categoryName) | |||
|
|
|||
| private bool IsUserLogCategory(string categoryName) | |||
| { | |||
| return LogCategories.IsFunctionUserCategory(categoryName) || categoryName.Equals(WorkerConstants.FunctionConsoleLogCategoryName, StringComparison.OrdinalIgnoreCase); | |||
| return LogCategories.IsFunctionUserCategory(categoryName) || categoryName.Equals(WorkerConstants.ConsoleLogCategoryName, StringComparison.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
Reflecting the change of renaming the constant to remove the "Function" prefix.
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new logger for tooling console log entries from language workers so that they are always logged as Informational irrespective of Host category level present in HOST.JSON
The dotnet language worker has a startup hook which emits some meta information about the language worker process (ex: processId). This information is emitted via standard output using Console.WriteLine API. The Host reads this std output stream and log that information using ILogger. We have a console logger which will print this in the console when in development mode, which IDE/Debuggers may read (the processId) so that they can attach to the process.
When the
host.JSONof dotnet isolated function app specify "Error" as the minimum log level for "Host" category, this information is not surfaced to console as ILogger will discard any log message with level below "Error". The tooling console log messages are sent as "Information" level one and thus being dropped.The fix here in this PR is having a separate ILogger for the tooling related log messages coming from worker. We identify the tooling related messages by checking the existence of a special prefix(
azfuncjsonlog:), and if detected, we will use the new logger for logging that message. This log level of this special logger is set toInformationalin code (Customers/Users are not supposed to change this), so that the log level value of "Host" category is not impacting this log entries.Relevant issue: Azure/azure-functions-dotnet-worker#900