fix(log): time waiting for appinsights to close was unbounded #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR, NPM Conformance Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
huntergregory
force-pushed
the
huntergregory/fix-appinsights-close
branch
from
272caee to
dd8c428
Compare
|
/azp run Azure Container Networking PR, NPM Conformance Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
reviewed
Jan 8, 2025
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
huntergregory
force-pushed
the
huntergregory/fix-appinsights-close
branch
from
9c32780 to
7e3ee76
Compare
|
/azp run Azure Container Networking PR, NPM Conformance Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rayaisaiah
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix: time waiting for appinsights to close was unbounded Signed-off-by: Hunter Gregory <[email protected]> * fix: close timer in case it hasn't fired yet Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]>
rayaisaiah
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix: time waiting for appinsights to close was unbounded Signed-off-by: Hunter Gregory <[email protected]> * fix: close timer in case it hasn't fired yet Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* test: [NPM] fix windows unit test for policymanager (#3161) * test: fix windows unit test for policymanager Signed-off-by: Hunter Gregory <[email protected]> * fix(test): flip bool Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]> * fix: [NPM] close telemetry handler before crashing (#3333) fix: close telemetry handler before crashing Signed-off-by: Hunter Gregory <[email protected]> * fix(log): time waiting for appinsights to close was unbounded (#3337) * fix: time waiting for appinsights to close was unbounded Signed-off-by: Hunter Gregory <[email protected]> * fix: close timer in case it hasn't fired yet Signed-off-by: Hunter Gregory <[email protected]> --------- Signed-off-by: Hunter Gregory <[email protected]> * resolved merge conflict as there isnt npm lite in v1.5 --------- Signed-off-by: Hunter Gregory <[email protected]> Co-authored-by: Hunter Gregory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When CNS (and NPM after #3333) crash, they block on a call to close the app insights client so that queued logs are sent. This relies on a channel which might not close until much after the timeout which NPM/CNS specify. The ApplicationInsights-Go repo recommends having a timer of our own for the maximum time we want to wait for app insights to close.
This PR changes CNS and NPM so that they wait at most 30 seconds.
Issue Fixed:
Related to #3299.
Requirements:
Notes: