Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: [NPM] fix windows unit test for policymanager #3161

Merged
merged 2 commits into from
Nov 26, 2024
Merged

test: [NPM] fix windows unit test for policymanager #3161

merged 2 commits into from
Nov 26, 2024

Conversation

huntergregory
Copy link
Contributor

Had this failure running Windows unit tests:

--- FAIL: TestBootup (0.00s)
    policymanager_test.go:118: 
        	Error Trace:	D:/a/_work/1/s/npm/pkg/dataplane/policies/policymanager_test.go:118
        	Error:      	Not equal: 
        	            	expected: "iptables-nft"
        	            	actual  : "iptables"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-iptables-nft
        	            	+iptables
        	Test:       	TestBootup

@huntergregory huntergregory added the npm Related to NPM. label Nov 21, 2024
@huntergregory huntergregory requested a review from a team as a code owner November 21, 2024 20:28
@huntergregory
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory
fix(test): flip bool
37548f3 
Signed-off-by: Hunter Gregory <[email protected]>
@huntergregory
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory huntergregory added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
@huntergregory
test: [NPM] fix windows unit test for policymanager (#3161)
a51ba21 
* test: fix windows unit test for policymanager

Signed-off-by: Hunter Gregory <[email protected]>

* fix(test): flip bool

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@huntergregory huntergregory added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@huntergregory huntergregory added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 5ac0e8c Nov 26, 2024
18 checks passed
@huntergregory huntergregory deleted the huntergregory/fix-windows-ut branch November 26, 2024 05:23
rayaisaiah pushed a commit that referenced this pull request Jan 14, 2025
@huntergregory @rayaisaiah
test: [NPM] fix windows unit test for policymanager (#3161)
a7904db 
* test: fix windows unit test for policymanager

Signed-off-by: Hunter Gregory <[email protected]>

* fix(test): flip bool

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>
rayaisaiah pushed a commit that referenced this pull request Jan 14, 2025
@huntergregory @rayaisaiah
test: [NPM] fix windows unit test for policymanager (#3161)
40a0a64 
* test: fix windows unit test for policymanager

Signed-off-by: Hunter Gregory <[email protected]>

* fix(test): flip bool

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>
@rayaisaiah rayaisaiah mentioned this pull request Jan 14, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2025
@rayaisaiah @huntergregory
[backport] [NPM] Backport NPM Changes for v1.5.41 (#3344)
b84dbfd 
* test: [NPM] fix windows unit test for policymanager (#3161)

* test: fix windows unit test for policymanager

Signed-off-by: Hunter Gregory <[email protected]>

* fix(test): flip bool

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>

* fix: [NPM] close telemetry handler before crashing (#3333)

fix: close telemetry handler before crashing

Signed-off-by: Hunter Gregory <[email protected]>

* fix(log): time waiting for appinsights to close was unbounded (#3337)

* fix: time waiting for appinsights to close was unbounded

Signed-off-by: Hunter Gregory <[email protected]>

* fix: close timer in case it hasn't fired yet

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>

* resolved merge conflict as there isnt npm lite in v1.5

---------

Signed-off-by: Hunter Gregory <[email protected]>
Co-authored-by: Hunter Gregory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayaisaiah rayaisaiah rayaisaiah approved these changes

Assignees
No one assigned
Labels
npm Related to NPM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huntergregory @rayaisaiah