-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete endpoint on cni state save failure #2577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2df6517
to
0b73337
Compare
tamilmani1989
requested changes
Feb 13, 2024
jpayne3506
reviewed
Feb 16, 2024
vipul-21
reviewed
Feb 20, 2024
tamilmani1989
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
In windows, it is possible to successfully create an HNS endpoint and then subsequently fail to write to the CNI statefile. While the CNI call fails, the HNS endpoint is never deleted, causing retries to fail because the HNS endpoint has already been created. As it is not possible to retrieve the existing endpoint on a retried ADD call, we instead opt to delete the HNS endpoint if saving the CNI state fails.
Issue Fixed:
See above.
Requirements:
Notes:
The code change affects both the windows and linux scenarios (if saving fails, deleteEndpoint will call the platform specific version for deletion of the endpoint). On windows, tested triggering a save failure and then examining HNS endpoints-- the endpoint is cleaned up which is confirmed in the logs. Without the fix, the endpoint still shows and produces the endpoint already exists (ip address claimed) error. On linux transparent-vlan mode, tested triggering a save failure, which does call into deleting the endpoint. Subsequent delete/adds for that pod run without erroring.