fix: delete endpoint on cni state save failure (#2577)

* Delete endpoint on cni state save failure

* Move code to defer

* Address feedback

* Log create endpoint error before deleting endpoint

* Adjust logs

Author: QxBytes

network/manager.go

@@ -393,9 +393,21 @@ func (nm *networkManager) CreateEndpoint(cli apipaClient, networkID string, epIn
 	if err != nil {
 		return err
 	}
+	// any error after this point should also clean up the endpoint we created above
+	defer func() {
+		if err != nil {
+			logger.Error("Create endpoint failure", zap.Error(err))
+			logger.Info("Cleanup resources")
+			delErr := nw.deleteEndpoint(nm.netlink, nm.plClient, nm.netio, nm.nsClient, nm.iptablesClient, ep.Id)
+			if delErr != nil {
+				logger.Error("Deleting endpoint after create endpoint failure failed with", zap.Error(delErr))
+			}
+		}
+	}()
 
 	if nm.IsStatelessCNIMode() {
-		return nm.UpdateEndpointState(ep)
+		err = nm.UpdateEndpointState(ep)
+		return err
 	}
 
 	err = nm.save()