Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add windows async delete mounts #2458

Merged
merged 3 commits into from
Dec 23, 2023
Merged

fix: add windows async delete mounts #2458

merged 3 commits into from
Dec 23, 2023

Conversation

jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Dec 21, 2023 •
edited
Loading

Reason for Change:

Updates the windows CNS daemonset to include the async delete path /var/run/azure-vnet in its volume mounts. Without the mount, windows CNS would OOM even if EnableAsyncPodDelete: false is read from the configmap.

Add the appropriate async delete fields to CNS configmaps

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added fix Fixes something. ci Infra or tooling. labels Dec 21, 2023
@jpayne3506 jpayne3506 requested a review from rbtr December 21, 2023 22:18
@jpayne3506 jpayne3506 self-assigned this Dec 21, 2023
@jpayne3506 jpayne3506 requested a review from a team as a code owner December 21, 2023 22:18
@jpayne3506 jpayne3506 enabled auto-merge December 21, 2023 22:18
@jpayne3506 jpayne3506 requested a review from vipul-21 December 21, 2023 22:21
@jpayne3506 jpayne3506 disabled auto-merge December 21, 2023 22:34
vipul-21
vipul-21 previously approved these changes Dec 21, 2023
View reviewed changes
rbtr
rbtr requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add the cns config to enable the feature in this change

@jpayne3506 jpayne3506 force-pushed the jpayne3506/mounts branch 3 times, most recently from 06a530c to c45dae9 Compare December 22, 2023 00:56
@jpayne3506 jpayne3506 enabled auto-merge December 22, 2023 20:39
rbtr
rbtr previously approved these changes Dec 22, 2023
View reviewed changes
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
Merged via the queue into master with commit f874f54 Dec 23, 2023
@jpayne3506 jpayne3506 deleted the jpayne3506/mounts branch December 23, 2023 16:25
paulyufan2 pushed a commit that referenced this pull request Jan 2, 2024
@jpayne3506 @paulyufan2
fix: add windows async delete mounts (#2458)
6ca9314 
* fix: add windows async delete mounts

* ci: enable async delete on cnsconfig maps

* ci: add mount overwrite to utils
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@jpayne3506 @matmerr
fix: add windows async delete mounts (#2458)
943dbb5 
* fix: add windows async delete mounts

* ci: enable async delete on cnsconfig maps

* ci: add mount overwrite to utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtr rbtr rbtr approved these changes

@vipul-21 vipul-21 vipul-21 left review comments

Assignees

@jpayne3506 jpayne3506

Labels
ci Infra or tooling. fix Fixes something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpayne3506 @rbtr @vipul-21