Skip to content

Commit 6ca9314

Browse files
jpayne3506paulyufan2
authored andcommitted
fix: add windows async delete mounts (#2458)
* fix: add windows async delete mounts * ci: enable async delete on cnsconfig maps * ci: add mount overwrite to utils
1 parent dda0a0e commit 6ca9314

6 files changed

+63
-4
lines changed

test/integration/manifests/cns/daemonset-windows.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ spec:
7474
mountPath: /etc/azure-cns
7575
- name: cni-conflist
7676
mountPath: /k/azurecni/netconf
77+
- name: azure-vnet
78+
mountPath: /var/run/azure-vnet
7779
ports:
7880
- containerPort: 10090
7981
hostPort: 10090
@@ -130,5 +132,9 @@ spec:
130132
hostPath:
131133
path: /k/azurecni/bin
132134
type: Directory # // TODO: add windows cni conflist when ready
135+
- name: azure-vnet
136+
hostPath:
137+
path: /var/run/azure-vnet
138+
type: DirectoryOrCreate
133139
serviceAccount: azure-cns
134140
serviceAccountName: azure-cns
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
apiVersion: v1
2+
kind: ConfigMap
3+
metadata:
4+
name: cns-config
5+
namespace: kube-system
6+
data:
7+
cns_config.json: |
8+
{
9+
"TelemetrySettings": {
10+
"TelemetryBatchSizeBytes": 16384,
11+
"TelemetryBatchIntervalInSecs": 15,
12+
"RefreshIntervalInSecs": 15,
13+
"DisableAll": false,
14+
"HeartBeatIntervalInMins": 30,
15+
"DebugMode": false,
16+
"SnapshotIntervalInMins": 60
17+
},
18+
"ManagedSettings": {
19+
"PrivateEndpoint": "",
20+
"InfrastructureNetworkID": "",
21+
"NodeID": "",
22+
"NodeSyncIntervalInSeconds": 30
23+
},
24+
"ChannelMode": "CRD",
25+
"InitializeFromCNI": true,
26+
"ManageEndpointState": false,
27+
"ProgramSNATIPTables" : false,
28+
"EnableCNIConflistGeneration": true,
29+
"CNIConflistFilepath": "/etc/cni/net.d/15-azure-swift-overlay.conflist",
30+
"CNIConflistScenario": "overlay",
31+
"EnableAsyncPodDelete": false,
32+
"AsyncPodDeletePath": "/var/run/azure-vnet/deleteIDs"
33+
}

test/integration/manifests/cnsconfig/azurecnidualstackoverlaywindowsconfigmap.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,7 @@ data:
2929
"MetricsBindAddress": ":10092",
3030
"EnableCNIConflistGeneration": false,
3131
"CNIConflistFilepath": "C:\\k\\azurecni\\netconf\\10-azure.conflist",
32-
"CNIConflistScenario": "dualStackOverlay"
32+
"CNIConflistScenario": "dualStackOverlay",
33+
"EnableAsyncPodDelete": false,
34+
"AsyncPodDeletePath": "/var/run/azure-vnet/deleteIDs"
3335
}

test/integration/manifests/cnsconfig/azurecnioverlaylinuxconfigmap.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,7 @@ data:
2727
"ProgramSNATIPTables" : false,
2828
"EnableCNIConflistGeneration": true,
2929
"CNIConflistFilepath": "/etc/cni/net.d/15-azure-swift-overlay.conflist",
30-
"CNIConflistScenario": "v4overlay"
30+
"CNIConflistScenario": "v4overlay",
31+
"EnableAsyncPodDelete": true,
32+
"AsyncPodDeletePath": "/var/run/azure-vnet/deleteIDs"
3133
}

test/integration/manifests/cnsconfig/azurecnioverlaywindowsconfigmap.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,7 @@ data:
2929
"MetricsBindAddress": ":10092",
3030
"EnableCNIConflistGeneration": false,
3131
"CNIConflistFilepath": "C:\\k\\azurecni\\netconf\\10-azure.conflist",
32-
"CNIConflistScenario": "v4overlay"
32+
"CNIConflistScenario": "v4overlay",
33+
"EnableAsyncPodDelete": true,
34+
"AsyncPodDeletePath": "/var/run/azure-vnet/deleteIDs"
3335
}

test/internal/kubernetes/utils_create.go

+15-1
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@ func initCNSScenarioVars() (map[CNSScenario]map[corev1.OSName]cnsDetails, error)
316316
cnsOverlayConfigMapPath := cnsConfigFolder + "/overlayconfigmap.yaml"
317317
cnsAzureCNIOverlayLinuxConfigMapPath := cnsConfigFolder + "/azurecnioverlaylinuxconfigmap.yaml"
318318
cnsAzureCNIOverlayWindowsConfigMapPath := cnsConfigFolder + "/azurecnioverlaywindowsconfigmap.yaml"
319+
cnsAzureCNIDualStackLinuxConfigMapPath := cnsConfigFolder + "/azurecnidualstackoverlaylinuxconfigmap.yaml"
319320
cnsAzureCNIDualStackWindowsConfigMapPath := cnsConfigFolder + "/azurecnidualstackoverlaywindowsconfigmap.yaml"
320321
cnsRolePath := cnsManifestFolder + "/role.yaml"
321322
cnsRoleBindingPath := cnsManifestFolder + "/rolebinding.yaml"
@@ -439,7 +440,7 @@ func initCNSScenarioVars() (map[CNSScenario]map[corev1.OSName]cnsDetails, error)
439440
"azure-swift-overlay-dualstack.conflist", "-o", "/etc/cni/net.d/10-azure.conflist",
440441
},
441442
initContainerName: initContainerNameCNI,
442-
configMapPath: cnsSwiftConfigMapPath,
443+
configMapPath: cnsAzureCNIDualStackLinuxConfigMapPath,
443444
installIPMasqAgent: true,
444445
},
445446
corev1.Windows: {
@@ -673,6 +674,15 @@ func volumesForAzureCNIOverlayWindows() []corev1.Volume {
673674
},
674675
},
675676
}, // TODO: add windows cni conflist when ready
677+
{
678+
Name: "azure-vnet",
679+
VolumeSource: corev1.VolumeSource{
680+
HostPath: &corev1.HostPathVolumeSource{
681+
Path: "/var/run/azure-vnet",
682+
Type: hostPathTypePtr(corev1.HostPathDirectoryOrCreate),
683+
},
684+
},
685+
},
676686
}
677687
}
678688

@@ -745,5 +755,9 @@ func cnsVolumeMountsForAzureCNIOverlayWindows() []corev1.VolumeMount {
745755
Name: "cni-bin",
746756
MountPath: "/k/azurecni/bin",
747757
}, // TODO: add windows cni conflist when ready
758+
{
759+
Name: "azure-vnet",
760+
MountPath: "/var/run/azure-vnet",
761+
},
748762
}
749763
}

0 commit comments

Comments
 (0)