ci: Add k8s network conformance tests to makefile #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it might be better to add the k8s tests to the main makefile where other test targets live since we primarily use the hackfile for provisioning clusters |
jpayne3506
force-pushed
the
jpayne3506/e2emake
branch
from
76238aa to
f4f9a8c
Compare
vipul-21
reviewed
Jul 27, 2023
| test-k8se2e: test-k8se2e-build test-k8se2e-only ## Alias to run build and test | ||
|
|
||
| test-k8se2e-build: ## Build k8s e2e test suite | ||
| cd hack/scripts && bash ./k8se2e.sh $(GROUP) $(CLUSTER) |
There was a problem hiding this comment.
Will this work? Given we don't have variables Group or Cluster in the file ?
There was a problem hiding this comment.
Yes, these scripts were heavily reliant on those arguments being present in command to begin with. Having a default did not provide any additional benefit.
jpayne3506
force-pushed
the
jpayne3506/e2emake
branch
from
f4f9a8c to
5c72f9a
Compare
jpayne3506
force-pushed
the
jpayne3506/e2emake
branch
from
5c72f9a to
22d2f85
Compare
4 tasks
camrynl
approved these changes
Jul 28, 2023
jpayne3506
added a commit
to jpayne3506/azure-container-networking
that referenced
this pull request
Jul 28, 2023
* Add k8s Network Conformance tests command to makefile * Add lines to README * Allow numbers to show in make help call * Addressing Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Allows for users to test cluster network conformance from the command line and give a single command to test network conformance in future CI.
Issue Fixed:
Requirements:
Notes:
Example commands: