-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci:[CNI] Windows datapath using k8se2e template #2041
Conversation
parameters: | ||
clusterName: "" | ||
|
||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there actually anything windows specific about this or could we reuse this template across all scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically, lines 45 and 47 are what is making this into a windows file. After looking into this I could add parameters to the load-test-template that calls it to ensure that this could be used for other k8s e2e.test testing. Thus, making it a better template.
1bbbb0c
to
ffea64a
Compare
e749438
to
06c324c
Compare
@@ -16,7 +16,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: noop | |||
image: mcr.microsoft.com/windows/nanoserver:ltsc2022 | |||
image: mcr.microsoft.com/oss/kubernetes/pause:3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of just changing this image, should evaluate if this deployment needs to be OS-specific or if there should only be one using (this) multiplat image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test on a separate branch and communicate with @vipul-21 to see what we should do going forward.
# Needs to be changed after #2032 is merged | ||
# test/integration/datapath/datapath_windows_test.go | ||
# does not test IPv6 at this time, waiting for #2032 | ||
go test -count=1 test/integration/datapath/datapath_win_test.go -timeout 3m -tags connection -run ^TestDatapathWin$ -tags=connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a make command for this ? Because we will be adding this to the PR pipeline and any future change would be easy to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2086 - Constrained to only network conformance, but very useful one line command.
2a9a1b3
to
e749438
Compare
d01b91b
to
800331c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
df5cd25
to
d6c939b
Compare
jobs: | ||
- template: ../k8s-e2e/k8s-e2e-job-template.yaml | ||
parameters: | ||
sub: $(TEST_SUB_SERVICE_CONNECTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to send the sub
as a parameter to the templates ?
Reason for Change:
Provides windows datapath tests through k8s e2e conformance testing to the load test pipeline.
Issue Fixed:
Requirements:
Notes:
PM for documented test coverage and ADO runs.
Will need to be updated after #2032 merges as file names will be changing for windows go tests.