Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

fix: add default toleration for all taints #1371

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 8, 2022

ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration

  • An empty key with operator Exists matches all keys, values and effects which means this will tolerate everything.

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration
- An empty `key` with operator `Exists` matches all keys, values and effects which means this will tolerate everything.

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase marked this pull request as ready for review December 8, 2022 18:33
@aramase aramase enabled auto-merge (squash) December 8, 2022 18:33
@aramase aramase merged commit 85c39cc into Azure:master Dec 8, 2022
@aramase aramase deleted the tolerate-all branch December 8, 2022 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants