fix: add default toleration for all taints (#1371)

ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration - An empty `key` with operator `Exists` matches all keys, values and effects which means this will tolerate everything. Signed-off-by: Anish Ramasekar <[email protected]>
Azure · Dec 8, 2022 · 85c39cc · 85c39cc
1 parent d90a976
commit 85c39cc
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 4 deletions.
diff --git a/manifest_staging/charts/aad-pod-identity/README.md b/manifest_staging/charts/aad-pod-identity/README.md
@@ -286,7 +286,7 @@ The following tables list the configurable parameters of the aad-pod-identity ch
 | `nmi.podAnnotations`                      | Pod annotations for NMI                                                                                                                                                                                                                                                                                                       | `{}`                                                                                                     |
 | `nmi.podLabels`                           | Pod labels for NMI                                                                                                                                                                                                                                                                                                            | `{}`                                                                                                     |
 | `nmi.affinity`                            | Affinity settings                                                                                                                                                                                                                                                                                                             | `{}`                                                                                                     |
-| `nmi.tolerations`                         | List of node taints to tolerate                                                                                                                                                                                                                                                                                               | `[]`                                                                                                     |
+| `nmi.tolerations`                         | List of node taints to tolerate                                                                                                                                                                                                                                                                                               | `[{"operator": "Exists"}]`                                                                               |
 | `nmi.ipTableUpdateTimeIntervalInSeconds`  | Override iptables update interval in seconds                                                                                                                                                                                                                                                                                  | `60`                                                                                                     |
 | `nmi.micNamespace`                        | Override mic namespace to short circuit MIC token requests                                                                                                                                                                                                                                                                    | If not provided, default is `default` namespace                                                          |
 | `nmi.probePort`                           | Override http liveliness probe port                                                                                                                                                                                                                                                                                           | If not provided, default is `8085`                                                                       |

diff --git a/manifest_staging/charts/aad-pod-identity/values.yaml b/manifest_staging/charts/aad-pod-identity/values.yaml
@@ -194,9 +194,10 @@ nmi:
   nodeSelector:
     kubernetes.io/os: linux
 
-  tolerations: []
-    # - key: "CriticalAddonsOnly"
-    #   operator: "Exists"
+  ## ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
+  ## An empty key with operator Exists matches all keys, values and effects which means this will tolerate everything.
+  tolerations:
+    - operator: "Exists"
 
   # ref: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity
   affinity: {}

diff --git a/manifest_staging/deploy/infra/deployment-rbac.yaml b/manifest_staging/deploy/infra/deployment-rbac.yaml
@@ -518,6 +518,8 @@ spec:
             port: 8085
           initialDelaySeconds: 10
           periodSeconds: 5
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux
 ---

diff --git a/manifest_staging/deploy/infra/deployment.yaml b/manifest_staging/deploy/infra/deployment.yaml
@@ -474,6 +474,8 @@ spec:
             port: 8085
           initialDelaySeconds: 10
           periodSeconds: 5
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux
 ---

diff --git a/manifest_staging/deploy/infra/managed-mode-deployment.yaml b/manifest_staging/deploy/infra/managed-mode-deployment.yaml
@@ -351,5 +351,7 @@ spec:
             port: 8085
           initialDelaySeconds: 10
           periodSeconds: 5
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux
diff --git a/manifest_staging/deploy/infra/noazurejson/deployment-rbac.yaml b/manifest_staging/deploy/infra/noazurejson/deployment-rbac.yaml
@@ -516,6 +516,8 @@ spec:
             port: 8085
           initialDelaySeconds: 10
           periodSeconds: 5
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux
 ---

diff --git a/manifest_staging/deploy/infra/noazurejson/deployment.yaml b/manifest_staging/deploy/infra/noazurejson/deployment.yaml
@@ -472,6 +472,8 @@ spec:
             port: 8085
           initialDelaySeconds: 10
           periodSeconds: 5
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux
 ---