Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker version to 24.0 and native SDK to 1.10 #100

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Upgrade Docker version to 24.0 and native SDK to 1.10 #100

merged 8 commits into from
Oct 18, 2023

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented Jun 16, 2023 •
edited
Loading

Updating Docker version to 24.0(.2) and use of ACAP native SDK to 1.8.
Some changes to handle deprecation and/or changes in respective build systems.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@madelen-at-work
Updated docker version to 24.0
befbdaa 
Change-Id: I7c781c71d742e7122f9c70080659672fe4d1360a
@madelen-at-work
fix lint issue
eb573d5 
Change-Id: I98d40a974c1033ff60bdc60c6dceeba8ae6e4899
@madelen-at-work
cleanup
09cb4ee 
Change-Id: I645a318a21c4cc62d88ce08bf22a62620f9ac3a4
@madelen-at-work
cleanup
fd6aac2 
Change-Id: I827576de3890e2b59c1341783cd7b42fe3b50487
@madelen-at-work madelen-at-work mentioned this pull request Jun 19, 2023
Merged
6 tasks
@madelen-at-work madelen-at-work changed the title Upgrade Docker version to 24.0 Upgrade Docker version to 24.0 and native SDK to 1.8 Jun 19, 2023
@madelen-at-work madelen-at-work marked this pull request as ready for review June 19, 2023 09:54
@madelen-at-work madelen-at-work requested a review from a team as a code owner June 19, 2023 09:54
@madelen-at-work madelen-at-work changed the title Upgrade Docker version to 24.0 and native SDK to 1.8 Upgrade Docker version to 24.0 and native SDK to 1.10 Oct 18, 2023
madelen-axis added 3 commits October 18, 2023 15:36
Rebase on main
af71086 
* main:
  Apply clang-format to dockerdwrapper.c
  Bump actions/checkout from 3 to 4
  build.sh: Stop at errors and/or unset parameters (#99)
  Remove build docker hub (#102)
  Fix build for Docker v 20.10.9 (#98)
clang again
e804e5c
remove .hcl that's no longer needed
76ceeee
@madelen-at-work madelen-at-work merged commit 4140822 into main Oct 18, 2023
@madelen-at-work madelen-at-work deleted the docker-version-24 branch October 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojju jojju jojju approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madelen-at-work @jojju