build.sh: Stop at errors and/or unset parameters #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we stop at errors, the script will keep going on with new commands even if the previous ones fail. It should fail early to make the build process more solid and comprehensible. Also fail at unset parameters, and remove superfluous quotes at variable assignment. Change-Id: Id26abd68d51ec6aaeef20779116f375688b98c69 Signed-off-by: Joakim Roubert <[email protected]>
| @@ -1,16 +1,16 @@ | |||
| #!/bin/sh | |||
| case "$1" in | |||
| #!/bin/sh -eu | |||
There was a problem hiding this comment.
I get failure on "HTTP_PROXY: unbound variable" when building locally due to the -u flag
Possibly we should remove the proxy build args but either way the -e should be enough I guess
There was a problem hiding this comment.
Ah, yes, my bad. I think keeping the -u but setting ${HTTP_PROXY:-} would be the best way forward. Then we signal that we accept HTTP_PROXY to be empty, but if there are any forgotten variables we will be made aware of it and nothing will go under the radar. I will update.
Signed-off-by: Joakim Roubert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Unless we stop at errors, the script will keep going on with new commands even if the previous ones fail. It should fail early to make the build process more solid and comprehensible.
Also fail at unset parameters, and remove superfluous quotes at variable assignment.
Checklist before requesting a review